-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect type for save
in Store<T>
#22
Labels
Comments
rvagg
added a commit
that referenced
this issue
Sep 16, 2021
rvagg
added a commit
that referenced
this issue
Sep 16, 2021
good catch, should be fixed in a patch release, thanks |
github-actions bot
pushed a commit
that referenced
this issue
Sep 16, 2021
### [2.0.6](v2.0.5...v2.0.6) (2021-09-16) ### Bug Fixes * correctly type save() and load() types as async ([da03346](da03346)), closes [#22](#22)
🎉 This issue has been resolved in version 2.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this example,
save
is defined as an async function:iamap/examples/level-backed.js
Lines 74 to 81 in 06d4402
But the return type for
save
is supposed to beT
, notPromise<T>
:iamap/interface.ts
Lines 1 to 7 in 06d4402
So I think the type should be changed to either
Promise<T>
orT | Promise<T>
.The text was updated successfully, but these errors were encountered: