Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/alignment_engine.cpp: support gcc-10 #28

Closed
wants to merge 1 commit into from
Closed

src/alignment_engine.cpp: support gcc-10 #28

wants to merge 1 commit into from

Conversation

emollier
Copy link

@emollier emollier commented May 2, 2020

Greetings,

This patch adds support for building spoa with Gcc 10 by explicitely introducing the now missing stdexcept header. It fixes the following build error, reported initially under Debian bug #957836:

[...]
/<<PKGBUILDDIR>>/src/alignment_engine.cpp:41:20: error: ‘invalid_argument’ is not a member of ‘std’
   41 |         throw std::invalid_argument("[spoa::createAlignmentEngine] error: "
      |                    ^~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/alignment_engine.cpp:45:20: error: ‘invalid_argument’ is not a member of ‘std’
   45 |         throw std::invalid_argument("[spoa::createAlignmentEngine] error: "
      |                    ^~~~~~~~~~~~~~~~

I hope this helps,
Kind Regards.

@rvaser
Copy link
Owner

rvaser commented May 4, 2020

Do you need a new release as well?

@emollier
Copy link
Author

emollier commented May 4, 2020

I guess it would be welcome to track version fixes. Sure, if you see fit.

@rvaser
Copy link
Owner

rvaser commented May 7, 2020

I have updated all submodules of Racon (including spoa). Can you please check the latest racon commit whether now everything compiles with GCC10?

As other files in spoa needed #include <stdexcept>, I did not merge this pull request.

@emollier
Copy link
Author

emollier commented May 7, 2020

I proceeded to a build of Racon including your latest commit. The result looks good, here is the build log, if you wish to have a look. Let me know if you need further testing.

@rvaser
Copy link
Owner

rvaser commented May 8, 2020

That will suffice, thank you. I will create a new release during today.

@rvaser rvaser closed this May 8, 2020
@emollier emollier deleted the patch-1 branch May 8, 2020 08:29
@emollier
Copy link
Author

emollier commented May 8, 2020

Great! You're welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants