Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for passing explicit t-gradient or Jacobian to stiff solver #33

Merged
merged 1 commit into from
May 15, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion REQUIRE
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ julia 0.5
BinDeps 0.4.3
Compat 0.17.0
Parameters 0.5.0
DiffEqBase 0.15.0
DiffEqBase 1.5.1
22 changes: 11 additions & 11 deletions src/common.jl
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ function solve{uType,tType,isinplace}(
kwargs...)

if verbose
warned = false
isempty(kwargs) || check_keywords(alg, kwargs, warnlist)
if has_tgrad(prob.f)
warn("Explicit t-gradient given to this stiff solver is ignored.")
warned = true
end
if has_jac(prob.f)
warn("Explicit Jacobian given to this stiff solver is ignored.")
warned = true
warned = !isempty(kwargs) && check_keywords(alg, kwargs, warnlist)
if !(typeof(prob.f) <: AbstractParameterizedFunction)
if has_tgrad(prob.f)
warn("Explicit t-gradient given to this stiff solver is ignored.")
warned = true
end
if has_jac(prob.f)
warn("Explicit Jacobian given to this stiff solver is ignored.")
warned = true
end
end
warned &&
warn("See http://docs.juliadiffeq.org/latest/basics/compatibility_chart.html")
warned && warn_compat()
end

if save_timeseries != nothing
Expand Down