Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of loading files in tests, fixes #14 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix order of loading files in tests, fixes #14 #16

wants to merge 1 commit into from

Conversation

mpapis
Copy link
Member

@mpapis mpapis commented Jun 25, 2017

The following line:

Dir[lib+"/**/*.rb"].each{|file| require file }

can have system dependent ordering, adding extra:

require "pluginator"

should ensure proper order of loading classes.

@mpapis mpapis mentioned this pull request Jun 25, 2017
Open
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9b989e6 on bugfix/ensure-order-of-loading-files-in-tests into e205d0e on master.

@mpapis mpapis mentioned this pull request Aug 27, 2017
Open
@logicminds
Copy link
Contributor

logicminds commented Sep 3, 2017 •
edited
Loading

This seems to fix the original issue. However, I am now getting other errors. Looking into those errors now.

@mpapis
Copy link
Member Author

mpapis commented Sep 10, 2017

share the errors, I might be able to help :)

@mpapis
Copy link
Member Author

mpapis commented Jan 25, 2018

@logicminds ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpapis @coveralls @logicminds