Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JRuby 9.2.0.0 #4390

Merged
merged 1 commit into from
May 27, 2018
Merged

Add support for JRuby 9.2.0.0 #4390

merged 1 commit into from
May 27, 2018

Conversation

HarlemSquirrel
Copy link
Contributor

No description provided.

@havenwood
Copy link
Member

I think the jruby[-9.1.17.0] here should be changed to jruby-9.1[.17.0] or omitted.

@HarlemSquirrel
Copy link
Contributor Author

@havenwood Makes sense to me. I've updated my branch.

@havenwood
Copy link
Member

I think this one should stay jruby[-9.2.0.0], since it's what you get if you just rvm install jruby.

@HarlemSquirrel
Copy link
Contributor Author

@havenwood OK, updated.

havenwood
havenwood approved these changes May 27, 2018
View reviewed changes
Copy link
Member

@havenwood havenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

@havenwood havenwood merged commit d4eba1a into rvm:master May 27, 2018
@pkuczynski pkuczynski added this to the rvm-1.29.4 milestone Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havenwood havenwood havenwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rvm-1.29.4
Development

Successfully merging this pull request may close these issues.
3 participants
@HarlemSquirrel @havenwood @pkuczynski