Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing macOS CI and re-enable the truffleruby test on macOS #5387

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Sep 5, 2023

It was disabled in #5119
and means this bug was not caught: #5385

@eregon
Copy link
Contributor Author

eregon commented Sep 5, 2023

The failure in macOS CI is unrelated: https://github.com/rvm/rvm/actions/runs/6084945174/job/16507919460?pr=5387
That will need to be fixed first.

@eregon eregon marked this pull request as draft September 5, 2023 14:43
pkuczynski
pkuczynski previously approved these changes Sep 8, 2023
@eregon eregon force-pushed the reenable-truffleruby-test-macos branch 2 times, most recently from f82798e to e420e42 Compare March 19, 2024 16:40
@eregon eregon mentioned this pull request Mar 19, 2024
@eregon eregon changed the title Re-enable the truffleruby test on macOS Fixing macOS CI and re-enable the truffleruby test on macOS Mar 19, 2024
@eregon
Copy link
Contributor Author

eregon commented Mar 19, 2024

So test/fast/* passes now: https://github.com/rvm/rvm/actions/runs/8349160490/job/22852712175?pr=5387
But for some reason truffleruby_comment_test fails without any output.
I wonder if maybe the previous CI steps delete ~/.rvm/scripts/rvm or cause that script to exit with 1.
Or maybe they just change the default ruby being used and tf is not found.

And indeed truffleruby_comment_test passes if run first: https://github.com/eregon/rvm/actions/runs/8349445042/job/22853649326

@eregon eregon force-pushed the reenable-truffleruby-test-macos branch 3 times, most recently from 2aa8686 to 3605524 Compare March 20, 2024 11:25
@eregon
Copy link
Contributor Author

eregon commented Mar 20, 2024

https://github.com/eregon/rvm/actions/runs/8358105456/job/22878671570
So ~/.rvm/scripts/rvm exists but:

Run source ~/.rvm/scripts/rvm && true
Error: Process completed with exit code 1.

So it seems somehow the fast tests break rvm somehow, to the point it even fails to be sourced and the only error is the exit code, only on macOS (not on Linux).
I'll workaround by running the truffleruby tests first then, that should work fine.

@eregon eregon force-pushed the reenable-truffleruby-test-macos branch from 3605524 to ed71a1f Compare March 20, 2024 11:58
@eregon eregon marked this pull request as ready for review March 20, 2024 12:55
@eregon eregon requested a review from pkuczynski March 20, 2024 12:56
@pkuczynski pkuczynski merged commit a9c478d into rvm:master Mar 20, 2024
4 checks passed
havenwood pushed a commit to havenwood/rvm-1 that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants