Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiftOut should be a method on board instances #68

Closed
rmurphey opened this issue Sep 7, 2012 · 0 comments
Closed

shiftOut should be a method on board instances #68

rmurphey opened this issue Sep 7, 2012 · 0 comments

Comments

@rmurphey
Copy link
Contributor

rmurphey commented Sep 7, 2012

I've been looking at http://www.arduino.cc/playground/Main/LedControl, which is a library for using a MAX7219 chip to control an LED matrix or a set of seven-segment displays. It uses the shiftOut functionality that I originally saw in shift register examples. Presently, johnny five implements the shiftOut functionality in the ShiftRegister API, but it doesn't provide it as a separate method. I think that this should actually be a method on board instances, rather than falling under the ShiftRegister API, because I'm understanding now that it has broader utility.

Pull request coming shortly, but more for discussion than necessarily to be landed.

rmurphey added a commit to rmurphey/johnny-five that referenced this issue Sep 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants