-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the right version of nightly to the documentation #519
Comments
This is in response to #513 |
Given the uncertainty brought on by #513, it seems prudent to specify which version of nightly to use in the documentation. This is something I was really hoping to avoid during Rocket's life as a nightly library by always building on the latest nightly. It's a real shame that an unrelated library's unwillingness to do what's best for the community has temporarily grounded Rocket. My thoughts are that we should indicate the proper nightly version in the getting started guide as well as the |
I had a brief look over your PR's for the ring library, I don't understand the unwillingness to cooperate on ring's behalf, especially in this case as you have already gone to the trouble fixing ring 0.11 for the latest nightly build. Yes I think this is a good idea. I think definitely in the 'Getting Started' guide as rustup can be a bit of a pain for even intermediate rust users. The 'Getting Started' and the |
Changes made and deployed! |
I'd like to suggest looking into the option of building Rocket without dependencies, aware this may need more effort, but believe will help not sticking in such situation again, Total.js framework is doing like this. |
It looks good to me! Hopefully when Rocket is ready for 0.4 we'll be able to support the newest nightlies again! |
Since the latest versions of nightly are breaking rocket due to the ring library drama, I was wondering if we could add:
~/.cargo/bin/rustup override set nightly-2017-12-18
for people who are new to rust? (2017-12-18 is the minimum requirement for pear-codegen and therefore rocket-codegen)The text was updated successfully, but these errors were encountered: