Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should INPUTS be mandatory when RESTORE_DB is skipped? #158

Closed
simonblake-mp opened this issue Apr 23, 2024 · 2 comments
Closed

Should INPUTS be mandatory when RESTORE_DB is skipped? #158

simonblake-mp opened this issue Apr 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@simonblake-mp
Copy link

Describe the bug
An existing v1.x pynonymizer config that has PYNONYMIZER_START_AT='ANONYMIZE_DB'works fine without setting PYNONYMIZER_INPUT. In v2 it looks like INPUT has become mandatory - running v2.x against the same set of env vars that worked with v1.x, I get :

Missing values for required arguments:
Missing INPUT
Missing STRATEGYFILE

To Reproduce
as above

Expected behavior
Feels like INPUT should only be mandatory if the RESTORE_DB step is going to be in play?

Additional context

@simonblake-mp simonblake-mp changed the title Should INPUTS be mandatory? Should INPUTS be mandatory when RESTORE_DB is skipped? Apr 23, 2024
@rwnx rwnx added the bug Something isn't working label Apr 25, 2024
@rwnx rwnx self-assigned this Apr 25, 2024
@rwnx rwnx added this to the v2.2.1 milestone Apr 25, 2024
@rwnx
Copy link
Owner

rwnx commented Apr 25, 2024

Thank you so much for taking the time to write this up. This change wasnt intentional, I'll take a look at this with the other issues. Watch the patch milestone for updates https://github.com/rwnx/pynonymizer/milestone/4

@rwnx
Copy link
Owner

rwnx commented Apr 30, 2024

I've run some tests my side and I think this is because of the changes in #159, rather than a change to behaviour. when using the env vars from 2.2.0 it seems to work.

@rwnx rwnx closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants