Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYNONYMIZER_STRATEGY dropped without deprecation #159

Closed
simonblake-mp opened this issue Apr 23, 2024 · 5 comments
Closed

PYNONYMIZER_STRATEGY dropped without deprecation #159

simonblake-mp opened this issue Apr 23, 2024 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@simonblake-mp
Copy link

Describe the bug
A working v1.x pynonymizer config that has env var PYNONYMIZER_STRATEGY set is failing with v2 :

Missing values for required arguments:
Missing INPUT
Missing STRATEGYFILE

There's no mention in the CHANGELOG of PYNONYMIZER_STRATEGY being deprecated vs PYNONYMIZER_STRATEGYFILE - I'm wondering if it's been unintentionally dropped, as at the moment it's a breaking change without a prior deprecation?

To Reproduce
as above

Expected behavior
either PYNONYMIZER_STRATEGY continues to work, or a deprecation message

Additional context

@simonblake-mp
Copy link
Author

likewise, PYNONYMIZER_START_AT (and presumably PYNONYMIZER_STOP_AT) have also been dropped without doc changes or a deprecation warning?

@rwnx rwnx added the bug Something isn't working label Apr 25, 2024
@rwnx rwnx self-assigned this Apr 25, 2024
@rwnx rwnx added this to the v2.2.1 milestone Apr 25, 2024
@rwnx
Copy link
Owner

rwnx commented Apr 25, 2024

Hi, thanks for reporting this. It looks like this was accidentally changed because of the differences in argument names in the new CLI library I'm using. This is absolutely a bug and I will restore the previous behaviour. I've added this to v2.2.1, stay tuned for updates.

@rwnx
Copy link
Owner

rwnx commented Apr 25, 2024

PYNONYMIZER_START_AT has been accidentally renamed to PYNONYMIZER_START_AT_STEP. I'll make sure this behaviour is reverted.

@simonblake-mp
Copy link
Author

I've changed my pipelines to use the new variable names, other folks have probably done the same - might be nice to deprecate the new names rather than just a revert?

@rwnx
Copy link
Owner

rwnx commented Apr 30, 2024

Good suggestion, thanks! Both variations will be supported in 2.2.1. Closing this, but let's keep talking if it's not fixed.

@rwnx rwnx closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants