Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mssql integration tests, Cached MSSQL updates #48

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

rwnx
Copy link
Owner

@rwnx rwnx commented Apr 7, 2021

  • add mssql integration tests using the rough structure from the other integration tests, but with a locally executing mssql instance
  • consolidate mssql setup in tests_integration/mssql/install_mssql.sh.
  • Should fix MSSQL: All lines in table are anonymized to same values #44 , and i've added a rough uniqueness test in the integration test to prove it.
  • As discovered during this PR, the odbc driver is different on different platforms (duh!) so i've added an "auto-detect" feature (and subsequent override cli opt) to manage this. this should give us the best of both worlds. the auto-detect is basically the first driver with the words sql server in it. it's pretty crude.

Caveat: occasionally the mssql instance just never comes online, and i'm not sure exactly what's causing it. asking the service to restart seemed to result in 30m wait times in previous runs, so i'm reluctant to go there.

Jerome Twell added 2 commits April 7, 2021 03:49
* Add basic smoke test for mssql
* Add uniqueness check for mssql
* Use a WHERE table.column LIKE % OR NULL pattern to correlate the
  tables together, to ensure no caching of subqueries should take place.
@rwnx rwnx merged commit c5ed9ab into master Apr 7, 2021
@rwnx rwnx deleted the mssql-integration-tests branch April 7, 2021 11:51
rwnx pushed a commit that referenced this pull request Mar 17, 2024
…ter'

Resolve "Add real database tests/Integration tests"

Closes #48

See merge request jerometwell/pynonymizer!58
rwnx pushed a commit that referenced this pull request Mar 17, 2024
Mssql integration tests, Cached MSSQL updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSSQL: All lines in table are anonymized to same values
1 participant