Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot() task in FairseqHydraTrainingJob #527

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

AndreasPlt
Copy link
Contributor

Currently, the task plot() in the FairseqHydraTrainingJob fails (as noted by @vieting off-line) due to an incorrect parsing of the hydra log file. I therefore corrected the parsing of this file to read the loss and LR values from the right lines.

@vieting
Copy link
Contributor

vieting commented Jul 9, 2024

@Judyxujj did you also have failing plot tasks? It does fail for the logs of wav2vec 2.0 pre-training. However, I'm not familiar enough with different fairseq setups to know whether this proposed change will break the task for the logs of other trainings.

@michelwi michelwi removed their assignment Jul 9, 2024
@vieting
Copy link
Contributor

vieting commented Jul 10, 2024

@michelwi can you tell why the AppTek hashes test fails? It can hardly be related to the proposed changes here, right?

@michelwi
Copy link
Contributor

@michelwi can you tell why the AppTek hashes test fails? It can hardly be related to the proposed changes here, right?

This is a fork of i6_core and not a branch, therefore it does not have access to our API key to trigger the pipeline and this step immediately fails.

@vieting
Copy link
Contributor

vieting commented Jul 10, 2024

This is a fork of i6_core and not a branch, therefore it does not have access to our API key to trigger the pipeline and this step immediately fails.

I see, thanks. Then we can just ignore this, changes inside the plot task can anyway never affect the hashes.

@vieting
Copy link
Contributor

vieting commented Aug 22, 2024

@Judyxujj could you please have a look at this PR? :)

@vieting vieting merged commit 80c0903 into rwth-i6:main Aug 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants