Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing synchronized keyword (Sonar) #33

Conversation

pixeebot[bot]
Copy link

@pixeebot pixeebot bot commented Feb 14, 2024

This change adds missing synchronized keyword to methods that override a synchronized method in the parent class.
Our changes look something like this:

  interface AcmeParent {
     synchronized void doThing();
  } 

  class AcmeChild implements AcmeParent {

    @Override
-    void doThing() {
+    synchronized void doThing() {
      thing();
    }
    
  }
More reading

Powered by: pixeebot (codemod ID: sonar:java/overrides-match-synchronization-s3551)

@pixeebot pixeebot bot mentioned this pull request Feb 14, 2024
@ryandens ryandens merged commit 02f67fe into main Feb 14, 2024
3 checks passed
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ryandens ryandens deleted the pixeebot/drip-2024-02-14-sonar-java/overrides-match-synchronization-s3551 branch February 14, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants