Correct spelling for action ADD_TRANSLATION_FOR_LANGUAGE #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdharrington
commented
Apr 14, 2018
adamdharrington
commented
- Fixes issue Mispelling #65
- Some othe private string spellings fixed
- Interface change @@localize/ADD_TRANSLATION_FOR_LANGUCorrect spelling for action ADD_TRANSLATION_FOR_LANGUAGE
- Fixes issue ryandrewjohnson#65 - Some othe private string spellings fixed - Interface change @@localize/ADD_TRANSLATION_FOR_LANGUCorrect spelling for action ADD_TRANSLATION_FOR_LANGUAGE
|
Yea this is tricky, as I didn't realize the actual exported action type also had a typo as well. I thought it was just the underlying string. As you mentioned in your comment, this could introduce a breaking change for anyone currently importing that action type. I don't want to release a breaking change, and I don't want to bump to the next major version for a change this small. So here's what I'm recommending... I'm in active development on the next major version right now, so what I'll probably do is take these changes and merge them directly into the v3 branch. Thanks again for catching these issues, and submitting the PR. |
|
Closing now that these changes have officially been added to v3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.