Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup-plugin-uglify to the latest version 🚀 #14

Merged
merged 3 commits into from
May 21, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 19, 2018

Version 4.0.0 of rollup-plugin-uglify was just published.

Dependency rollup-plugin-uglify
Current Version 3.0.0
Type devDependency

The version 4.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of rollup-plugin-uglify.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes v4 and back to es5

uglify-es is not supported anymore so we returned back to old school uglify-js. If you still want to transpile es6+ try rollup-plugin-terser. Terser is actively developed fork of uglify-es with the new name.

In this version we changed the way to import plugin. Now it looks like this

import { uglify } from 'rollup-plugin-uglify';

export default {
...
plugins: [uglify()]
...
}

To see more prettier errors uglify shows also babel code frame

    > 1 | var = 1
        |    ^ Name expected

Error: Error transforming bundle with 'uglify' plugin: Name expected

Commits

The new version differs by 6 commits.

  • a847d2e 4.0.0
  • cd8f9f1 Change default export to named one
  • 6e46a12 Use uglify-js as uglify-es got deprecated in favour of terser (#42)
  • 3beec87 Merge pull request #40 from kzc/patch-1
  • 5c07826 have README point to uglify-es docs
  • 3dc7600 Fix tests

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@coveralls
Copy link

coveralls commented May 21, 2018

Pull Request Test Coverage Report for Build 95

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.118%

Totals Coverage Status
Change from base Build 88: 0.0%
Covered Lines: 46
Relevant Lines: 46

💛 - Coveralls

@ryanhefner ryanhefner merged commit e7a339b into master May 21, 2018
@ryanhefner ryanhefner deleted the greenkeeper/rollup-plugin-uglify-4.0.0 branch May 21, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants