Add exception handling + CI lint step #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
reviewed
Feb 8, 2024
| @@ -19,7 +19,7 @@ export SRT_PASSWORD=<YOUR_SRT_PASSWORD> | |||
|
|
|||
| pip install -e ".[test]" | |||
|
|
|||
| black SRT | |||
| pre-commit run --all-files | |||
1. IP block case 2. Responsebody without resultMap case 3. Update installation.md python requirement
1. Add black version as test dependency 2. Add pre-commit as test dependency 3. Update docs/contribution.md ryanking13#259 (comment)
kujyp
commented
Feb 8, 2024
Comment on lines
+2
to
+3
| - Add exception handling | ||
| ([#259](https://github.com/ryanking13/SRT/issues/259)) |
kujyp
commented
Feb 8, 2024
| @@ -27,7 +27,8 @@ Changelog = "https://github.com/ryanking13/SRT/blob/master/CHANGELOG.md" | |||
| test = [ | |||
| "pytest", | |||
| "pytest-httpserver", | |||
| "black", | |||
| "black==23.12.1", | |||
There was a problem hiding this comment.
#260 (comment)
black 최신버전에서 동작이 변경되었습니다
kujyp
commented
Feb 8, 2024
| @@ -1,6 +1,6 @@ | |||
| # Installation | |||
|
|
|||
| > Python Support: SRTrain requires **Python version >= 3.6** | |||
| > Python Support: SRTrain requires **Python version >= 3.10** | |||
ryanking13
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #259