-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font Monaspace #1403
Comments
Is someone doing this issue ? Is it hard to do ? |
There is a part of contributing.md that says how to do it: https://github.com/ryanoasis/nerd-fonts/blob/master/contributing.md#steps-for-adding-a-new-font-or-removing-an-existing-font |
@kraklin I made a PR |
PR: #1405 |
The PR is filled in with -=> We need a substitute nameAs |
|
|
I like MoonSpace |
Monabase or Monasbase |
|
Given how "Mononoki" (another RFN font with a similar license) is handled, can we not do the same here and use "Monaspace Nerd Font"? |
Well, Nerd Fonts got an exemption from Mononoki's RFN license clause [1]. [1] #575 (comment) |
Oh, 100% -- I don't know enough to know what the right thing to do is. :) In that case, should we @-mention one of the people on Githubnext's end to see if this is something that they'd grant an exception for? |
Dear @idan! There is a overwhelming demand for your great new font We do not touch the existing glyphs (except is some rare cases we drop one-cell-wide Because Maybe you and your team can consider this RFN exception with the additional condition that we will always add our name to the font names to make the distinction clear for users. Any answer (negative or positive) is appreciated. Thank you! Fini This is how the naming would come out, also note some warnings.
After merging The ID16 changed to Edit: Add information on ID16 change |
I am super hyped for this and of course everyone immediately wanted nerdfont and powerline. Recovering today from the launch, I will be back to figure this out next week! |
See also: githubnext/monaspace#24 |
Maybe some of you want to try the patched font out, and report bugs. So we can fix the issues before release? MonispaceNeonNerdFont.tar.xz.gz Thank you! P.S.: The archive is |
This comment was marked as resolved.
This comment was marked as resolved.
No, as the name states that is Neon only. I thought one variant would be enough for tests? Is Krypton better? |
You mean Monispace instead of Monaspace, or Or |
this |
Quite a lot of the fonts have I guess that is not an for Neon, but Krypton will have small issues:
Fonts with some abbreviation mode active, Nerd Font becomes NF when the value is >= 4: $ git grep makegroups
3270/config.cfg:config_patch_flags="--makegroups 2"
CascadiaCode/config.cfg:config_patch_flags="--makegroups 4"
FiraCode/config.cfg:config_patch_flags="--makegroups 2"
Hasklig/config.cfg:config_patch_flags="--makegroups 2"
IntelOneMono/config.cfg:config_patch_flags="--makegroups 4"
Iosevka/config.cfg:config_patch_flags="--makegroups 4"
IosevkaTerm/config.cfg:config_patch_flags="--makegroups 4"
IosevkaTermSlab/config.cfg:config_patch_flags="--makegroups 4"
JetBrainsMono/config.cfg:config_patch_flags="--makegroups 4"
MPlus/config.cfg:config_patch_flags="--makegroups 2"
MartianMono/config.cfg:config_patch_flags="--name filename --makegroups 5"
Monaspace/config.cfg:config_patch_flags="--makegroups 4"
Noto/config.cfg:config_patch_flags="--makegroups 5"
Overpass/config.cfg:config_patch_flags="--makegroups 2"
RobotoMono/config.cfg:config_patch_flags="--makegroups 3"
SourceCodePro/config.cfg:config_patch_flags="--makegroups 4"
Ubuntu/config.cfg:config_patch_flags="--makegroups 2"
UbuntuMono/config.cfg:config_patch_flags="--makegroups 2"
VictorMono/config.cfg:config_patch_flags="--makegroups 4" |
But you are right, maybe better just use mode
I will check that out, thanks for bringing it up! :-) Edit: Ah no, ... you see... looks bad.
|
@Finii Are the variable fonts also supported? Or only the static ones? |
@jla2000 Nerd Font uses Fontforge which can not (really) work with variable fonts (VF). There is a loose plan to allow VF in the future but for this Fontforge needs to be exchanged to fonttools, and that is kind of a rewrite at least in some parts (i.e. will not come soon, unfortunately). (Can not find the relevant thread at the moment.) Edit: I believe it came up with |
Font looks nice btw in Windows Terminal 💯 |
@Finii the font does not support full Vietnamese character set like the original font |
@ntcong Ugg!?!! I will check, thanks for reporting. Can you give me some copy and paste text that should work? |
Here a few word and a (should be) complete set of character
|
Update from our end: alas, like other commercial fonts, we have to get Legal involved because Nerdfont has lots of logos of businesses. I have a hard time forecasting how long this is going to take. But the good news is that there might be some work already happening for Cascadia Code (also MSFT) which we might be able to follow in the footsteps of. Stay tuned, just wanted to let you know that we're trying to figure this out! In the meanwhile, I understand that folks are going to produce patched versions. I hope one day to make the patched versions obsolete! Stay tuned. |
@idan Thanks for the feedback! Yes I also had discussions about this with Aaron already ;-) I think for the time being we need to do a rename. Do you have any preference as name? |
Monaspace
Other renames we do
I asked around and most people found Monaspice the nicest and best pun. |
Big thanks to all who suggested names: @cyklee @kraklin @loraderon @redactedscribe 💚 |
@Finii Sorry, I know that this is closed, but just a heads up: The link to Monaspice from the main page is broken. It directs to the following url, which gives a 404.: https://github.com/ryanoasis/nerd-fonts/blob/master/patched-font/Monaspace |
@firasrb I think it will be in next release (3.1.0) |
It will
And release is within minutes, just preparing Brew now
Sent from Nine
…________________________________
From: Alejandro Cámara ***@***.***>
Sent: Tuesday, November 21, 2023 15:41
To: ryanoasis/nerd-fonts
Cc: Fini; Mention
Subject: Re: [ryanoasis/nerd-fonts] Add font Monaspace (Issue #1403)
@firasrb I think it will be in next release (3.1.0)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Is it just me or does Monaspice look like it's always emboldened? (Monaspice on the left with FiraCode for comparison): I downloaded Monaspice via the scoop-nerd-fonts Scoop bucket. Haven't used the official non-patched Monaspace so I can't say if this is expected. The Monaspice font used is |
Please, create a regular issue if you have an issue. |
https://github.com/githubnext/monaspace
Version 1.0.0 just released.
It has an interesting idea to change the cell size visibly to make more room (if possible) for wide letters like
m
if they are next to small letters likei
while keeping the cell grit intact.The text was updated successfully, but these errors were encountered: