Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecast doesn't include UV index #2

Closed
ryansurf opened this issue May 13, 2024 · 2 comments
Closed

Forecast doesn't include UV index #2

ryansurf opened this issue May 13, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ryansurf
Copy link
Owner

The forecast only includes wave data(height, period, direction)

It should have UV index info too.

The API info can be found here

In helper.py, we have the forecast() function for the ocean data. Reference that/add to that for the UV forecast.

@ryansurf ryansurf added help wanted Extra attention is needed good first issue Good for newcomers labels May 13, 2024
@Hummus-Ful
Copy link
Contributor

Should this be closed? It seems to be implemented by api.get_uv()

@ryansurf
Copy link
Owner Author

Should this be closed? It seems to be implemented by api.get_uv()

Its not quite implemented. We get the current UV when we run:

ryan@debian:~$ curl localhost:8000


Location:  San Diego



      .-``'.
    .`   .`
_.-'     '._
        
UV index:  3.2
Wave Height:  4.0
Wave Direction:  254.0
Wave Period:  9.1

But if we want a forecast and run:

ryan@debian:~$ curl localhost:8000?forecast=5


Location:  San Diego



      .-``'.
    .`   .`
_.-'     '._
        
UV index:  3.2
Wave Height:  4.0
Wave Direction:  254.0
Wave Period:  9.1


Date:  2024-07-22 07:00:00+00:00
Wave Height:  4.1
Wave Direction:  251.2
Wave Period:  9.4


Date:  2024-07-23 07:00:00+00:00
Wave Height:  3.3
Wave Direction:  242.0
Wave Period:  10.4


Date:  2024-07-24 07:00:00+00:00
Wave Height:  3.0
Wave Direction:  233.9
Wave Period:  10.6


Date:  2024-07-25 07:00:00+00:00
Wave Height:  3.3
Wave Direction:  234.5
Wave Period:  10.0


Date:  2024-07-26 07:00:00+00:00
Wave Height:  4.3
Wave Direction:  246.6
Wave Period:  9.2

We only get the current UV. There is a api.forecast() function which may need to be modified to achieve this

ryansurf pushed a commit that referenced this issue Aug 21, 2024
merge to forked branch all the newest changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants