Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests #193

Closed
wants to merge 9 commits into from
Closed

Added unit tests #193

wants to merge 9 commits into from

Conversation

Hakky54
Copy link
Contributor

@Hakky54 Hakky54 commented May 21, 2020

No description provided.

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #193   +/-   ##
=========================================
  Coverage     91.28%   91.28%           
  Complexity      127      127           
=========================================
  Files            44       44           
  Lines           413      413           
  Branches         52       52           
=========================================
  Hits            377      377           
  Misses            9        9           
  Partials         27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86275dd...89283e0. Read the comment docs.

Hakky54 and others added 2 commits May 21, 2020 13:56
…ync/HttpDeleteAsyncDslTest.kt

Co-authored-by: Sergei Rybalkin <yan.brikl@gmail.com>
@Hakky54
Copy link
Contributor Author

Hakky54 commented May 21, 2020

By the way I initially thought that these unit tests aren't present so I added it. But then I discovered a different package which also has similar unit tests. Any idea why this is the case?

For example the HttpDeleteAsyncDslTest:

  • kohttp/src/test/kotlin/io/github/rybalkinsd/kohttp/dsl/async/HttpDeleteAsyncDslTest.kt
  • kohttp-test/src/test/kotlin/io/github/rybalkinsd/kohttp/dsl/async/HttpDeleteAsyncDslTest.kt

@rybalkinsd
Copy link
Owner

Any idea why this is the case?

:kohttp-test depends on both :kohttp an :kohttp-jackson and any other module we will introduce in the future.

.asJson function from :kohttp-jackson simplifies tests.

@Hakky54
Copy link
Contributor Author

Hakky54 commented May 21, 2020

Ah okay, that makes sense

@Hakky54 Hakky54 closed this May 30, 2020
@Hakky54 Hakky54 deleted the increase-code-confidence branch May 30, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants