Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response extension functions #84

Closed
wants to merge 13 commits into from
Closed

Response extension functions #84

wants to merge 13 commits into from

Conversation

gokulchandra
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #84 into release/0.8.0 will decrease coverage by 1.64%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release/0.8.0      #84      +/-   ##
===================================================
- Coverage            97.22%   95.57%   -1.65%     
  Complexity             106      106              
===================================================
  Files                   32       32              
  Lines                  288      294       +6     
  Branches                17       21       +4     
===================================================
+ Hits                   280      281       +1     
  Misses                   2        2              
- Partials                 6       11       +5
Impacted Files Coverage Δ Complexity Δ
...ithub/rybalkinsd/kohttp/dsl/context/HttpContext.kt 95.23% <100%> (-2.33%) 14 <0> (ø)
...lin/io/github/rybalkinsd/kohttp/ext/ResponseExt.kt 82.35% <20%> (-10.76%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b3b06...49e231f. Read the comment docs.

@gokulchandra
Copy link
Collaborator Author

@rybalkinsd Could you take a look at this?

Linked issue: #65

@gokulchandra
Copy link
Collaborator Author

@rybalkinsd Do you think this is good to be merged?

@rybalkinsd rybalkinsd closed this May 9, 2019
@rybalkinsd
Copy link
Owner

@gokulchandra Yeah, looks good for me. I just removed release/0.8.0 branch and created a new release/0.9.0. Could u pls change PR destination?

@rybalkinsd
Copy link
Owner

The only thing that is m/b possible to improve here is

The diff coverage is 33.33%

according to codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants