Reorganize code #55
Merged
Reorganize code #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having very long files with lots of indepedent behavior, we can test the code in the same file it is written, and this proves to be a much better way of organizing things anyhow. In effect, each impl for a given trait gets a file, and all of the pertinent behavior is tested in the same file. This means that there should be very few external "use" statements within the tests mod, except in cases where an impl is expected to use another trait or impl somewhere. Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com> Tested-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
+ Coverage 97.78% 98.4% +0.61%
=========================================
Files 10 12 +2
Lines 451 125 -326
=========================================
- Hits 441 123 -318
+ Misses 10 2 -8
Continue to review full report at Codecov.
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38.
Now, each
implwill live in its own module, along with the tests for that impl. As a result, mosttestsmods will need just ause super::*;to function properly.