This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
Youtube api update #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
query param 'signature' > 'sig'
|
maybe it's related to this recent ytdl-core commit: fent/node-ytdl-core@1f79df3 I wish we could all merge our various yt libraries into some universal language and then compile it to the other languages. but until then... |
|
Thanks for chiming in! Fix added. |
SogoCZE
added a commit
to SogoCZE/ytdl
that referenced
this pull request
Jul 6, 2019
Closed
codesoap
reviewed
Oct 3, 2019
| if v, ok := format.meta["sp"].(string); ok && v != "" { | ||
| sigParam = v | ||
| } | ||
|
|
There was a problem hiding this comment.
It's a nit-pick, but @rylio only rarely uses blank lines within functions. I feel like it doesn't belong here. Do with this comment as you please.
|
I've tested this and am using it in one of my apps 👍 |
|
This has been fixed in the current master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like youtube is migrating ?signature= to ?sig=, a bunch of videos are returning 403's for all formats while others work perfectly fine.
Changing the param to
sigfixed the 403's and didn't break the ones that worked withsignature.I'm not sure about all of this, so... yeah.