Improve viomi.vacuum.v8 (styj02ym) support #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
==========================================
- Coverage 80.88% 80.81% -0.07%
==========================================
Files 157 157
Lines 15338 15405 +67
Branches 3350 3419 +69
==========================================
+ Hits 12406 12450 +44
- Misses 2676 2699 +23
Partials 256 256
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rytilahti
force-pushed
the
feat/viomi_improvements
branch
from
888b6b4
to
857c2ee
Compare
rytilahti
force-pushed
the
feat/viomi_improvements
branch
from
89795d1
to
40a9d35
Compare
|
I'll merge this now to make it simpler to test & develop against the master branch. |
|
Can't wait to see this working on my Home Assistant. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: the naming of properties and methods have been adjusted to be more clear about their intention, enums with boolean values have been replaced with booleans.
This PR improves support for viomi vacuums and aims to make it available for homeassistant without custom components (like https://github.com/KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym). While this has been developed against "Mi Robot Vacuum-Mop P" (viomi.vacuum.v8, styj02ym), it should work on all other viomivacuum supported vacuums. Thanks to @KrzysztofHajdamowicz for providing access to a test device :-)
This is related to #1495 and requires using https://github.com/rytilahti/home-assistant/tree/xiaomi_miio/feat/entities_from_upstream for the time being. The screenshot below shows the current (WIP) state.
Closes #1161
Closes #750
Closes #1003
TODO:
Some notes: