user can leave anime score as is when prompted #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryukinix
requested changes
Dec 31, 2017
mal/core.py
Outdated
| entry.get('score', 0)) | ||
| ).strip() | ||
| if user_score: # do nothing if blank answer | ||
| try: entry['score'] = int(user_score) |
There was a problem hiding this comment.
Please, keep the PEP8 format, break the lines.
mal/core.py
Outdated
| ).strip() | ||
| if user_score: # do nothing if blank answer | ||
| try: entry['score'] = int(user_score) | ||
| except ValueError: print(color.colorize('Invalid score.', 'red')) |
|
Yes I tested finishing up a show and keeping it without a score, keeping it with the current (non empty) score and changing the current score. Also tested the check for giving non numeric input. Regarding linting I'm not sure how to break up the input line. |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 84.23% 84.59% +0.35%
==========================================
Files 9 8 -1
Lines 368 357 -11
==========================================
- Hits 310 302 -8
+ Misses 58 55 -3Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #75. Pinging @ryukinix and @evanjs to see if you guys agree.