pkcs1 fix #159
Merged
pkcs1 fix #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 10, 2019 13:47
… data has been encrypted with different padding type than was encrypted. The library correctly returned data instead of throw error)
…und when data has been encrypted with different padding type than was encrypted. The library correctly returned data instead of throw error)" This reverts commit fb8f507.
… data has been encrypted with different padding type than was encrypted. The library correctly returned data instead of throw error)
|
Hi! Thanks for PR! Could you please provide some tests for this case? |
|
Hello, your current tests are working. I can try write some. But this is crazy case. And the problem was in usage of the library (encrypt with padding A, decrypt with padding B.). I can try it :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: pkcs1 returned Buffer object when data were invalid.
I found it when I tried to decrypt data with different padding type than i used during encryption. It was bug in my code. But the library returns invalid data instead of throw an error.
Your code contains some checks for this case, but there is AND instead of OR operator. My data had first byte 0 and second byte random value. In this case the condition failed.
I supose that the library have to throws an error, when first byte is not 0 and second is not 2 during decryption with padding pkcs1.