v4 #21
Merged
v4 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2024
Closed
It doesn't do anything different from Default.
- Exposes InstructionDecoder, DecodingState, and Instruction at the top level of the crate - Removes top-level visibility for register data structures - Removes public visibility for the decoder module The goal is to make imports self-documenting by encouraging verbosity, while keeping the most important structures accessible at the top level. For example, it is not obvious that a dez80::Condition relates to a conditional instruction rather than something related to the decoder, whereas importing dez80::Instruction::Condition makes the association clearer.
Displacement operands affect behavior significantly, so in a progressive decoding scenario it is useful to distinguish between displacement and non-displacement operands. Without distinct DecodingState variants or another signaling mechanism, it is not always possible to detect a displacement operand with limited context of the decoder's state, because indexed instruction tables include some instructions with only non-displacement operands, as well as both types of operands. While disambiguation is only strictly necessary for indexed instructions, for consistency this also replaces the IndexedBitwiseOperand variant with IndexedBitwiseDisplacement, since all bitwise indexed instructions have a displacement as their only operand, as well as RootDisplacement, used in relative jumps.
This includes updates to CLI parsing syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DecodingStateBonus: hopefully gets rid of the spooky security warning on GitHub.