Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bunch of typos #189

Closed
wants to merge 1 commit into from
Closed

Conversation

MichaelChirico
Copy link

@MichaelChirico MichaelChirico commented Jun 18, 2019

Originally saw the typo in rJava.c as I'd installed JDK12 on my new machine.

Decided while I'm at it to run

aspell(list.files('man', full.names = TRUE), filter = 'Rd')
aspell(list.files('R', full.names = TRUE, pattern = '\\.R$'), filter = 'R')
aspell(list.files('src', full.names = TRUE))
aspell('NEWS')
aspell(list.files('tests', full.names = TRUE))

And found the following typos in there. Cheers.

@@ -147,7 +147,7 @@ const char *rj_char_utf8(SEXP s) {
#endif

HIDE void deserializeSEXP(SEXP o) {
_dbg(rjprintf("attempt to deserialize %p (clCL=%p, oCL=%p)\n", o, clClassLoader, oClassLoader));
_dbg(rjprintf("attempt to deserialize %p (clCl=%p, oCL=%p)\n", o, clClassLoader, oClassLoader));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is to match the case used in loader.c

@s-u
Copy link
Owner

s-u commented Apr 7, 2021

Wow, thanks a lot! I have merged this by hand in 93679f2 since the code has diverged since.

@s-u s-u closed this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants