Delete key not working

[mquandalle]

Hello,

I've noticed a bug with the Delete key handling. Let's say I have an input field with the number USD 1,000 in it. Let's use | to represent the cursor position.

Current State	Key pressed	Expected	Resulting state
`USD 1,	000`	Backspace	`USD 1
`USD 1	,000`	Delete	`USD 1,

Does that make sense?

[s-yadav]

Its a bug. I will fix this. Thanks

…

On Jan 31, 2017 21:26, "Maxime Quandalle" ***@***.***> wrote: Hello, I've noticed a bug with the Delete key handling. Let's say I have an input field with the number USD 1,000 in it. Let's use | to represent the cursor position. Current State Key pressed Expected Resulting state USD 1,|000 Backspace USD 1|,000 USD 1|,000 (Correct) USD 1|,000 Delete USD 1,|000 USD 1|,000 (Bug) Does that make sense? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#21>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC9AvhV80gQPWT09z3RnEUdqZ9XUPBceks5rX1mRgaJpZM4Ly0Ap> .

[mquandalle]

Well actually on second though, I would say that the expected behavior is to delete a digit every time Detete or Backspace is pressed, like so:

Current State	Key pressed	Expected
`USD 1	,500`	Backspace
`USD 1,	500`	Backspace
`USD	500`	Backspace
`USD 1	,500`	Delete
`USD 1,	500`	Delete

This could be implemented by registering an handler onKeyDown to handle event.keyCode 8 (for Backspace) and 46 (for Delete).

What do you think @s-yadav?

[s-yadav]

Yes I have done the same fix. Will push it with some other changes.

[s-yadav]

Somehow I feel, it's better to have your first case (that is just changing the cursor position). The second case seems visually wrong and confuses (at least to me).

[s-yadav]

@mquandalle Can you cross check version 1.1.0-alpha or branch 1.1.0-alpha.

[mquandalle]

Version 1.1.0-alpha looks good to me (I've just read to code, not tested yet).

About my second suggestion, maybe this could be an option? At least in French, when the group delimiter is a blank space, moving the cursors doesn't make much sense.

[s-yadav]

Moving cursor does not feel very odd, but deleting a character not near to cursor feels odd, mainly when doing backspace, and behaviour of backspace and delete should be same just on other direction.
Lets keep the first case. Anyway as long user is able to delete we are ok.