Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit for negative number support #46

Merged
merged 2 commits into from
May 7, 2017
Merged

Initial commit for negative number support #46

merged 2 commits into from
May 7, 2017

Conversation

jagkum
Copy link

@jagkum jagkum commented Mar 31, 2017 •
edited
Loading

Sorry I have to format your code and add some prop validation in order to use it as per my project

  1. Added new prop as allowNegative
  2. If allowNegative and you enter '-' anywhere in the input it will add '-' before the prefix
  3. If you enter '-' second time and if number is already negative it will remove '-'

@jagkum jagkum mentioned this pull request Apr 4, 2017
Closed
@s-yadav
Copy link
Owner

s-yadav commented Apr 4, 2017

Can you set indent to 2 and commit again?

@jagkum
Copy link
Author

jagkum commented Apr 5, 2017

@s-yadav I chnaged tab indent and committed again. Now you can compare easily.

@radulucaciu
Copy link

This would be helpful to me as well - can this be merged?

@psalchow
Copy link

+1

1 similar comment
@ShannonStoner
Copy link

+1

@s-yadav s-yadav merged commit 528c385 into s-yadav:master May 7, 2017
@s-yadav
Copy link
Owner

s-yadav commented May 7, 2017

Merged with few fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jagkum @s-yadav @radulucaciu @psalchow @ShannonStoner