Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass currentTarget to onFocus #815

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

csantos1113
Copy link
Contributor

@csantos1113 csantos1113 commented Nov 23, 2023

Describe the issue/change

This change is based on https://stackoverflow.com/a/66086044 currentTarget: only exists if used right from the onFocus event; but we get currentTarget null because onFocus(e) is called within a timeout.

References:

@csantos1113
Copy link
Contributor Author

Hey @s-yadav - I'm gently pinging you for when you get a chance to review this PR. Thank you!

@csantos1113
Copy link
Contributor Author

@s-yadav 👋 when you get a chance, this would be much appreciated!

@s-yadav
Copy link
Owner

s-yadav commented Feb 25, 2024

Hey @csantos1113 , was little occupied with some personal things for last 4 months, so didn't check.
The changes looks good. Please do accompany the fix with a test.

@s-yadav
Copy link
Owner

s-yadav commented Feb 25, 2024

Never mind I added test, and merging this.

@s-yadav s-yadav merged commit ad85c02 into s-yadav:master Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants