Made compatible with last bioptim version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbailly
changed the title
|
@pariterre Pariterre, you can merge in a branch with a tag refering to the updated version of Bioptim. But before, please go through my PR in Bioptim, because I had to make a necessary changes in custom penalty. |
|
@pariterre this PR is compatible with https://github.com/pyomeca/bioptim/releases/tag/Release_1.2.0 ! |
fbailly
changed the title
pariterre
approved these changes
May 9, 2021
Comment on lines
+174
to
+175
| self.constraints.add(maximal_tau, phase=i, node=Node.ALL, minimal_tau=self.tau_min, | ||
| get_all_nodes_at_once=True) |
| @@ -13,7 +13,7 @@ def generate_table(out): | |||
|
|
|||
| # IPOPT | |||
| ocp = prepare_ocp(biorbd_model_path=model_path) | |||
| opts = {"linear_solver": "ma57"} | |||
| opts = {"linear_solver": "ma57", "print_level": 0} | |||
There was a problem hiding this comment.
ma57 and print_level=0 gives highly misleading error message. I fear this will lead to think that the examples are broken (instead of their installation is wrong...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged in a branch called something like "bioptim_updated"