-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N Remover Tool #4
Comments
The nremover part is working. I need to incorporate the changes into the code with new IO. |
When you are ready for it to be looked over, please do a pull request. If you have any questions about that, let me know and I will be happy to help out. Also, be sure you have a header file with the core functionality that you have unit test for. |
Has anything been written down algorithmically for these tools? What are the assumptions, what is the goal, what is the alg (where was it derived from) Matt From: David Streett notifications@github.com When you are ready for it to be looked over, please do a pull request. If you have any questions about that, let me know and I will be happy to help out. Also, be sure you have a header file with the core functionality that you have unit test for. — |
Hey @msettles, Good to hear from you. :) So, N remover will be a simple O(N) algorithm that will loop through the entire read and get the longest non-n chunk possible. If this non-n chunk is greater than the minimum length requirement it is kept. If it isn't it is discarded. If it is a PE and only R1 is discarded, and the stranded option is set, R2 will become a SE RC read. Otherwise, the stand alone read will stay the same if its mate is discarded. Sound good? Did that answer your question or did I miss something? I'm going to hop on over to the Poly AT question #26 stuff now and talk about sliding windows. :) |
How about we put that in the help text or README? On Wed, Sep 7, 2016 at 10:14 AM, David Streett notifications@github.com
Joe Angell |
Yes help text / Readme and that was a general question for ALL the algs, that way concept folks like myself (who don’t have time to dig into code) can look through and poke any holes that might be present! Great description, thanks, and can’t think of any holes at the moment ;) Matt From: Joe Angell notifications@github.com How about we put that in the help text or README? On Wed, Sep 7, 2016 at 10:14 AM, David Streett notifications@github.com
Joe Angell — |
Yep, everything will be in 3 locations. Readme, --help (-h), and on the gitio pages and I will reuse them in my thesis . . . after a bit more development on the applications themselves. :) |
I didn’t realize the stranded part. Can you explain what an "SE RC" read is? What does “RC” stand for? Thanks |
Returns the longest sequence without Ns
The text was updated successfully, but these errors were encountered: