Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary fix for issue-47 - reporting isn't working #50

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

s8sg
Copy link
Owner

@s8sg s8sg commented Apr 27, 2023

No description provided.

Signed-off-by: s8sg <swarvanusg@gmail.com>
@s8sg
Copy link
Owner Author

s8sg commented Apr 30, 2023

@dan-ash Can you review this once

@s8sg s8sg assigned s8sg and dan-ash and unassigned s8sg Apr 30, 2023
@s8sg s8sg marked this pull request as draft April 30, 2023 03:15
@s8sg
Copy link
Owner Author

s8sg commented Apr 30, 2023

@dan-ash Can you review once

@s8sg
Copy link
Owner Author

s8sg commented May 17, 2023

Fixes #47

@dan-ash
Copy link
Collaborator

dan-ash commented May 21, 2023

@s8sg as far as I remember I tested this and it seems to solve the issue.
Regarding tracing, everything worked fine with the old version of Jager, migrating to OpenTelemetry should be done in another PR.

So I think we can merge this one

@s8sg s8sg marked this pull request as ready for review June 1, 2023 02:17
@s8sg s8sg merged commit 1dcf46b into master Jun 7, 2023
@s8sg s8sg deleted the issue-47 branch June 21, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants