Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

added the greeting message file #868

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

mayankmohak
Copy link
Contributor

@mayankmohak mayankmohak commented Oct 20, 2020

resolved this issue : Add an action on pull request and new issue for an automatic reply #738

Issue: feature request as in #738

make it hacktoberfest

@mayankmohak
Copy link
Contributor Author

mayankmohak commented Oct 20, 2020

adding more please read as 👎
GitHub doesn't allow access to a fork based pull request from a workflow yet!
Once they add this support I'll change code accordingly. link

i have tested it at the owners repo of this action: link

@mayankmohak mayankmohak reopened this Oct 20, 2020
@shahednasser
Copy link
Collaborator

Why is this action using checkout though? It's unnecessary as it is not related to the code of the repo. Refer to this action for an example on this.

@mayankmohak
Copy link
Contributor Author

mayankmohak commented Oct 21, 2020

@shahednasser that action is only for first timers welcome.
as mentioned in the issue the requirement was for making greet to all

@shahednasser shahednasser merged commit 55bde7a into sButtons:test-welcome-action Oct 21, 2020
@shahednasser
Copy link
Collaborator

I understand I'm not asking to use that action, I was just referring to the checkout part. I'll merge this now, please create a PR to this branch afterwards. Thank you.

@mayankmohak
Copy link
Contributor Author

mayankmohak commented Oct 21, 2020

o sorry for that i got that latter.
i will update it as updates arrived.

@deep5050
Copy link

hi @shahednasser I'm the owner of the action.

This is just to notify you that it now supports commenting on pull requests from other contributors.
You can remove the checkout part from the workflows ,it is indeed unnecessary now.
chack my repo's readme for details.

Thanks

@shahednasser
Copy link
Collaborator

Hello @deep5050 thank you for letting me know as this is of great help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants