Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bear Strength does not buff attack when revealed during counterstrike step #343

Closed
sIKE23 opened this issue Feb 15, 2016 · 9 comments
Closed

Comments

@sIKE23
Copy link
Owner

sIKE23 commented Feb 15, 2016

Lightning Raptor attacks Johktari Beastmaster with Electric Bite!
sike23 rolls 5 attack dice
sike23 rolled 0 normal damage, 2 critical damage, and 3 on the effect die
Lightning Raptor inflicts 2 damage on Johktari Beastmaster... (a below average roll)
Johktari Beastmaster retaliates with Basic Melee Attack!
schwenkgott pays 3 mana.
schwenkgott reveals Bear Strength!
schwenkgott rolls 3 attack dice
schwenkgott rolled 0 normal damage, 4 critical damage, and 4 on the effect die
see?
Johktari Beastmaster inflicts 4 damage on Lightning Raptor! (an above average roll)
revealed bear str and only 3 dice


@sIKE23 sIKE23 added this to the Q1--2016 Release milestone Feb 15, 2016
@sIKE23
Copy link
Owner Author

sIKE23 commented Feb 15, 2016

What would be really cool, looking at this output, is if we noted that the JBM was guarding:

Lightning Raptor attacks the Guarding Johktari Beastmaster with Electric Bite!

@sIKE23 sIKE23 changed the title Bear Strength not buff attack when revealed during counterstrike step Bear Strength does not buff attack when revealed during counterstrike step Feb 18, 2016
@ACG8
Copy link
Collaborator

ACG8 commented Feb 19, 2016

Should be easy enough to add (re: recognizing guarding). You just have to check whether there is a guard marker.

Was occupied this week, but may have some time this weekend to fix some of these issues.

@ACG8
Copy link
Collaborator

ACG8 commented Feb 22, 2016

I found the issue. Everything is working perfectly. I am assuming that your Johktari Beastmaster had a stagger when you tested this, right? (from a previous attack from the lightning raptor). When I have the JBM attack the lightning raptor with no stagger condition, she has 5 attack. So I think the problem is that you successfully implemented stagger :)

@sIKE23
Copy link
Owner Author

sIKE23 commented Feb 22, 2016

Was there no issue?
On Feb 21, 2016 10:52 PM, "Ananda" notifications@github.com wrote:

I found the issue. Everything is working perfectly. I am assuming that
your Johktari Beastmaster had a stagger when you tested this, right? (from
a previous attack from the lightning raptor). When I have the JBM attack
the lightning raptor with no stagger condition, she has 5 attack. So I
think the problem is that you successfully implemented stagger :)


Reply to this email directly or view it on GitHub
#343 (comment).

@ACG8
Copy link
Collaborator

ACG8 commented Feb 22, 2016

Yeah. As far as I can tell, there is no problem.

@sIKE23
Copy link
Owner Author

sIKE23 commented Feb 22, 2016

What about the guarding bit?

@ACG8
Copy link
Collaborator

ACG8 commented Feb 22, 2016

Haven't worked that in yet, but that is a separate issue. Perhaps we should change the title of this issue to focus on that.

@sIKE23
Copy link
Owner Author

sIKE23 commented Feb 22, 2016

Close this as won't fix, open another one?
On Feb 21, 2016 11:24 PM, "Ananda" notifications@github.com wrote:

Haven't worked that in yet, but that is a separate issue. Perhaps we
should change the title of this issue to focus on that.


Reply to this email directly or view it on GitHub
#343 (comment).

@ACG8 ACG8 added the Won't fix label Feb 22, 2016
@ACG8
Copy link
Collaborator

ACG8 commented Feb 22, 2016

Sure.

@ACG8 ACG8 closed this as completed Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants