Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trample as an Attack type #346

Closed
sIKE23 opened this issue Feb 26, 2016 · 10 comments
Closed

Add Trample as an Attack type #346

sIKE23 opened this issue Feb 26, 2016 · 10 comments

Comments

@sIKE23
Copy link
Owner

sIKE23 commented Feb 26, 2016

Needed for Lost Grimore, the [Trample] is the name of the attack in the AttackBar of the set data.

@sIKE23 sIKE23 added this to the Q1--2016 Release milestone Feb 26, 2016
ACG8 added a commit that referenced this issue Feb 29, 2016
Not a lot of automation needed here; Trample is now a recognized special
rangetype for an attack.
@ACG8
Copy link
Collaborator

ACG8 commented Feb 29, 2016

Aside from storing it in a dictionary (as a rangetype), is anything else needed here?

@sIKE23
Copy link
Owner Author

sIKE23 commented Feb 29, 2016

Just want to be able to draw an Arrow and use the attack....

On Sun, Feb 28, 2016 at 6:20 PM, Ananda notifications@github.com wrote:

Aside from storing it in a dictionary (as a rangetype), is anything else
needed here?


Reply to this email directly or view it on GitHub
#346 (comment).

@sIKE23
Copy link
Owner Author

sIKE23 commented Mar 5, 2016

Trample

Once per round, when a creature moves out of a zone, it may make a trample attack as a free action against a target creature in its zone. This means that the attack can only be used when you take a move action to leave the zone. The attack occurs during the move action, during the “leaving zone effects step”. This means you may only attack a creature in the zone you are leaving, not the zone you are entering. There is a special trample icon for trample attacks.

Trample attacks are considered melee attacks and must attack eligible targets. However, trample attacks are not affected by traits that would normally affect melee attacks. This includes Melee +X, Melee -X, Bloodthirsty +X, Charge +X, or any other traits that may affect melee attacks. After moving, your creature is still able to take a quick action as normal, which might be making another melee attack.
Trample attacks may only

@sIKE23
Copy link
Owner Author

sIKE23 commented Mar 5, 2016

@ACG8
The important part is

 trample attacks are not affected by traits that would normally affect melee attacks. This includes Melee +X, Melee -X, Bloodthirsty +X, Charge +X, or any other traits that may affect melee attacks.

@ACG8
Copy link
Collaborator

ACG8 commented Mar 6, 2016

Ah. It is inconvenient that they are considered melee attacks. I guess I will make trample an action type instead of a rangetype.

@sIKE23
Copy link
Owner Author

sIKE23 commented Mar 6, 2016

They are much like counterstrike from a implementation perspective....

On Sat, Mar 5, 2016 at 6:39 PM, Ananda notifications@github.com wrote:

Ah. It is inconvenient that they are considered melee attacks. I guess I
will make trample an action type instead of a rangetype.


Reply to this email directly or view it on GitHub
#346 (comment).

@ACG8
Copy link
Collaborator

ACG8 commented Mar 6, 2016

I can't sync for some reason, and am not sure how to debug the repo. Can you think of anything that might be the problem?

ACG8 added a commit that referenced this issue Mar 6, 2016
I think this should do it. Made trample into an action type instead of a
rangetype (which is more accurate anyway), since it is considered to be
a melee attack.
@sIKE23
Copy link
Owner Author

sIKE23 commented Mar 18, 2016

@ACG8
Bear Strength is buffing the Titanodons Trample attack still....

@ACG8
Copy link
Collaborator

ACG8 commented Mar 20, 2016

I found the issue. It is a problem with the formatting in the xml file. The relevant line currently reads

<property name="AttackBar" value="Gore:&#xD;&#xA;[Quick] [Melee] [Dice=5] [+2 vs. Corporeal Conjurations]&#xD;&#xA;Thundering Footsteps:&#xD;&#xA; [Trample] [Melee] [Dice=7]"

But it should read
<property name="AttackBar" value="Gore:&#xD;&#xA;[Quick] [Melee] [Dice=5] [+2 vs. Corporeal Conjurations]&#xD;&#xA;Thundering Footsteps:&#xD;&#xA;[Trample] [Melee] [Dice=7]"

In other words, there should not be a space before [Trample], as this is causing the character-stripping step (in which [ and ] characters on the outside of a string are removed) to fail.

Since this xml file is not currently included in the branch (due to NDA reasons, I assume), I will not upload a commit but will instead rely on you fix the problem (the issue is with the file I got from the playtester dropbox, and I can't edit that.)

Basically, there should be no spaces between the name of the attack and the first trait of the attack.

@sIKE23
Copy link
Owner Author

sIKE23 commented Apr 10, 2016

This is now working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants