Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: switch custom provider test to DO #184

Merged
merged 1 commit into from
Aug 18, 2023
Merged

bugfix: switch custom provider test to DO #184

merged 1 commit into from
Aug 18, 2023

Conversation

sa7mon
Copy link
Owner

@sa7mon sa7mon commented Aug 18, 2023

Vultr is not reliable enough for our automated tests. Switch the custom provider to DigitalOcean, eventually we should spin up a local S3 server and assert the API calls are being made correctly.

@github-actions
Copy link

Code Coverage

Package Line Rate Complexity Health
github.com/sa7mon/s3scanner 22% 0
github.com/sa7mon/s3scanner/bucket 90% 0
github.com/sa7mon/s3scanner/db 73% 0
github.com/sa7mon/s3scanner/permission 77% 0
github.com/sa7mon/s3scanner/provider 81% 0
Summary 62% (476 / 767) 0

@sa7mon sa7mon merged commit 1e0faec into main Aug 18, 2023
8 checks passed
@sa7mon sa7mon deleted the custom-test branch August 18, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant