Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible redundant line? #7

Closed
tangjm opened this issue Feb 17, 2023 · 1 comment
Closed

Possible redundant line? #7

tangjm opened this issue Feb 17, 2023 · 1 comment

Comments

@tangjm
Copy link

tangjm commented Feb 17, 2023

What's the reasoning behind this line

sign = sign > 0 ? 1 : -1
?

Is it to allow for flexibility in letting us use any positive integer to represent Black and any negative integer to represent White?
I think this would, however, never see its use if we made use of the type file.

@yishn
Copy link
Member

yishn commented Mar 22, 2023

I didn't want to throw an error for invalid values of sign.

@yishn yishn closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants