I have to modify code in Goban so that it can be built using preact-cli

[golf-x]

I have to modify code in Goban right this so it can be built in preact-cli without any problems, am i missing something here ?

[yishn]

You’re probably using an old version of preact. Use a version that supports getDerivedStateFromProps, such as 8.4.2.

[golf-x]

Upgraded to preact 8.4.2 but still does not work

[yishn]

Can you build and run the demo?

[golf-x]

Can you build and run the demo?

Yes, I can.

[golf-x]

I create a new preact project using create-preact-app with material template here and use Goban in shudan. it does not work.

Here is the git repository.
https://github.com/restingisimportant/preact-cli-shudan

Also i don't know why the stone does not appeared now, i must be missing something

[yishn]

In the git repository, you’re using an old version of preact. Are you sure you tried updating preact to 8.4.2?

[golf-x]

In the git repository, you’re using an old version of preact. Are you sure you tried updating preact to 8.4.2?

Hi, Sorry i forgot to update it for this one, now i updated it already. but problems still persist.

Also, the board does not show up completely

[yishn]

I suspect it's a transpilation issue of [...Array(n)]. I've changed it to Array(n).fill(0) to circumvent it. Can you try updating Shudan to v1.3.12 and see if it's working for you?

[golf-x]

Board does show correctly now.

However, build command still not success.

You can test by this repository
https://github.com/restingisimportant/preact-cli-shudan

[yishn]

It seems like preact-cli doesn't support getDerivedStateFromProps during prerender yet. Either don't use prerender (by running preact build --no-prerender like it suggested) or use the non-stable next version of preact-cli.

[golf-x]

It seems like preact-cli doesn't support getDerivedStateFromProps during prerender yet. Either don't use prerender (by running preact build --no-prerender like it suggested) or use the non-stable next version of preact-cli.

I got issue about preact build --no-prerender before. it does work now.
Thank you very much.