Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to sync with saber cloud #1304

Closed
2 tasks done
JustDj-Git opened this issue Jul 2, 2024 · 19 comments · Fixed by #1319
Closed
2 tasks done

Unable to sync with saber cloud #1304

JustDj-Git opened this issue Jul 2, 2024 · 19 comments · Fixed by #1319
Labels
bug Something isn't working

Comments

@JustDj-Git
Copy link

Before submitting an issue, please check the following

  • I have searched for similar issues (both open and closed) and cannot find a duplicate
  • I agree to follow the Code of Conduct

Describe the bug

Unable to sync with saber cloud. I tried to:
-create a new acc
-change devices (tried on Samsung tab s9, tab s6, nothing phone 1 and 2, appimage and flatpak versions on Linux
-reinstall saber everywhere

sometimes files are synced with cloud (I can see them in cloud) but if I delete notes from my pad/phone - I cant resync them

Error on Linux (flatpak):
flutter: WARNING: SaberSyncInterface: Failed to get sync file from remote file: Exception: Decryption failed for Saber/
flutter: WARNING: SaberSyncInterface: Failed to get sync file from remote file: Invalid argument(s): Invalid or corrupted pad block

To reproduce

  1. Sign-in on tab + phone (or more devices)
  2. Create any note and sync
  3. Try to sync notes on other devices - nothing happens

Expected behavior

Sync :)

Saber version

v0.24.1

Device

  • Devices: Linux PC, Samsung s9 tab, Samsung tab s6, nothing phone 1 and 2
  • OS: Debian, Arch, OpenSUSE, Fedora, Android

Anything else?

No response
@JustDj-Git JustDj-Git added the bug Something isn't working label Jul 2, 2024
@TekkertheChaot
Copy link

TekkertheChaot commented Jul 2, 2024 •
edited
Loading

same here! have the same bahaviour using the flatpack 0.24.1 on linux and 0.24.1 on android.
I also saw the same journal entry described above.

I've attached a video reproducing this behavior
https://github.com/saber-notes/saber/assets/17234581/10b83ebd-3871-45e2-804c-d9931bc8bb7a

EDIT: I use my own nextcloud but have the exact same behaviour

@gewinh
Copy link

gewinh commented Jul 3, 2024

Same here Saber v0.24.1 syncs to the nextcloud server with what looks like the right file size, but there is no syncing between my Android devices. I have a phone and a tablet each has the same version of saber and each is setup to sync to the same Nextcloud account with the same encryption password. They both sync there files to the saber folder but files created on the phone don't show up on the tablet and viz versa. I have also installed Saber on ubuntu as a snap and have the same issue, no syncing between devices. I am running Nextcloud 29.02 behind an nginx reverse proxy. Other apps that are using nextcloud sync are working fine. eg. Moonreader, files, notes deck etc.

While we are at it although I love the Saber software, I don't like the app lock in, by forcing encryption when you sync to Nextcloud (this should be optional). If for some reason Saber goes away or stops working, I would need to get to my notes another way. There are plenty of encryption options external from Saber that a user could choose, if they decided they needed that level of security. Thanks again for the great work

@TekkertheChaot
Copy link

TekkertheChaot commented Jul 3, 2024 •
edited
Loading

@gewinh
Regarding the encryption, I absolutely support you on that! IMO this should be an option for the user to decide.
The enabled encryption (which is great to provide encryption by default) could be a default recommendation, which can be disabled on setup behind a "I know what I'm doing" button or similar.
Please create a separate, trackable issue for this as this issue #1304 should only be tracking the sync issue. ;)

@Lennart01
Copy link

This issue was introduced after 0.23.0.
I can get syncing to work flawlessly between my android devices on that version.

@mar565
Copy link

mar565 commented Jul 5, 2024 •
edited
Loading

This issue was introduced after 0.23.0. I can get syncing to work flawlessly between my android devices on that version.

Thank you for the fix. Can confirm this issue on 0.24.1 FOSS version with own NC.

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Jul 7, 2024

While we are at it although I love the Saber software, I don't like the app lock in, by forcing encryption when you sync to Nextcloud (this should be optional). If for some reason Saber goes away or stops working, I would need to get to my notes another way. There are plenty of encryption options external from Saber that a user could choose, if they decided they needed that level of security. Thanks again for the great work

The "App lock in" isn't actually that bad. You can freely export your notes (to PDF or SBA), if you want to. I think it's good enough for the use-case you described. But, as @TekkertheChaot said, don't mix up two things in one issue, please. If you want to discuss this a bit more, create a new issue/discussion for it.

@Lennart01 Lennart01 mentioned this issue Jul 8, 2024
Closed
2 tasks
@Iey4iej3 Iey4iej3 mentioned this issue Jul 12, 2024
Closed
@github-actions github-actions bot mentioned this issue Jul 13, 2024
Open
@charitarthchugh
Copy link

Just curious, has this been fixed with v0.24.2?

@QubaB
Copy link
Contributor

QubaB commented Jul 17, 2024

Syncing was rewritten in 0.24.0

@TekkertheChaot
Copy link

Syncing was rewritten in 0.24.0

Yeah but the issue persists in 0.24.1 so this needs attention

@QubaB
Copy link
Contributor

QubaB commented Jul 17, 2024

see #1314

@QubaB QubaB mentioned this issue Jul 19, 2024
Closed
@adil192 adil192 mentioned this issue Jul 20, 2024
Merged
@adil192 adil192 linked a pull request Jul 20, 2024 that will close this issue
fix(sync): correct format of decrypted paths #1319
Merged
adil192 added a commit that referenced this issue Jul 20, 2024
@adil192 @QubaB
fix(sync): correct format of decrypted paths (#1319)
54d7f77 
* test: ensure files are decrypted correctly

* fix: relativeLocalPath shouldn't start with documents dir

A huge thank you to @QubaB for their work finding the problem in #1314

This commit fixes the problem slightly earlier in the syncing process, and adds a test for it

Closes #1306, Closes #1304, Closes #1314

Co-Authored-By: QubaB <74395874+QubaB@users.noreply.github.com>
@TekkertheChaot
Copy link

TekkertheChaot commented Jul 22, 2024 •
edited
Loading

Trying to sync with v0.24.3 clients (flatpack and android) unfortunately still has this issue:
Jul 22 16:25:51 Veldin flatpak[3725]: flutter: WARNING: SaberSyncInterface: Failed to get sync file from remote file: Exception: Decryption failed for Saber/
I had fresh-installed app in both plattforms and removed the previous Saber files on Nextcloud.

@adil192 Can we reopen this issue or should we create a dupe?

@adil192
Copy link
Member

adil192 commented Jul 22, 2024

That message is expected behaviour, it's just because Saber/ is a folder and not a file

@TekkertheChaot
Copy link

TekkertheChaot commented Jul 22, 2024 •
edited
Loading

That message is expected behaviour, it's just because Saber/ is a folder and not a file

Hmm, alright. Either way, I can't seem to sync notes between devices.
So this message probably doesn't relate to the sync issue?
Should I record another reproduction with the new versions? Maybe I am missing something crucial...

@JustDj-Git
Copy link
Author

The problem still persists - can't sync between devices...

@bryanpaget
Copy link

I also am unable to sync between devices.

@TekkertheChaot
Copy link

@adil192, sorry to ping you like this but (as other people are also pointing out) this issue still persists.
Can you reopen, please?

@bryanpaget
Copy link

bryanpaget commented Jul 24, 2024 •
edited
Loading

I have four devices connected to a self-hosted nextcloud instance, a ThinkPad running Ubuntu, Steam Deck, Samsung phone, and a Samsung tablet. All devices connect to the server, and all think they are syncing. But I have four separate sets of synced files. It's like the devices sync to the server in their own isolated storage compartments.

@TekkertheChaot TekkertheChaot mentioned this issue Jul 31, 2024
Closed
@TekkertheChaot
Copy link

TekkertheChaot commented Jul 31, 2024 •
edited
Loading

I have opened a new issue #1326 in hopes to avoid it being overlooked.
Hopefully someone of the moderators / contributors can sort this out.

(I know this is dirty and not the intended way of handling / against the CoC, but I'm trying to keep this on the radar as long as I cannot contribute something useful by myself to the project ❤️)

@TekkertheChaot
Copy link

For anyone still having this issue and monitoring this thread, it seems this issue is being tracked by #1320 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sync): correct format of decrypted paths saber-notes/saber
10 participants
@JustDj-Git @bryanpaget @TekkertheChaot @adil192 @charitarthchugh @gewinh @ceskyDJ @mar565 @QubaB @Lennart01