Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import sbn/sbn2 when in root folder #977

Merged
merged 7 commits into from
Nov 18, 2023

Conversation

ZebraVogel94349
Copy link
Contributor

This fixes the import of .sbn and .sbn2 files into the root directory. When widget.path was null, importFile() was called with the parameter 'null/' which caused the file not to be imported. Also, this makes the imported note open correctly after importing by removing the file extension from the path (previously, an empty .sbn2.sbn2 file was opened).

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (58406d9) 37.31% compared to head (a4bc5b5) 37.33%.
Report is 1 commits behind head on main.

Files Patch % Lines
lib/pages/home/recent_notes.dart 0.00% 9 Missing ⚠️
lib/components/home/new_note_button.dart 0.00% 4 Missing ⚠️
lib/components/home/move_note_button.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
+ Coverage   37.31%   37.33%   +0.01%     
==========================================
  Files         106      106              
  Lines        7729     7741      +12     
==========================================
+ Hits         2884     2890       +6     
- Misses       4845     4851       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adil192 adil192 enabled auto-merge (squash) November 18, 2023 13:27
@adil192 adil192 merged commit cb53963 into saber-notes:main Nov 18, 2023
2 checks passed
@adil192
Copy link
Member

adil192 commented Nov 18, 2023

Thanks!

@adil192 adil192 linked an issue Nov 18, 2023 that may be closed by this pull request
@ZebraVogel94349 ZebraVogel94349 deleted the bugfix branch November 29, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import to the root directory
2 participants