Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-router): switch to app router #1252

Merged
merged 7 commits into from
Apr 16, 2024
Merged

feat(app-router): switch to app router #1252

merged 7 commits into from
Apr 16, 2024

Conversation

sabertazimi
Copy link
Owner

  • Refactor ant design, sandpack, and nprogress usage.
  • Remove next-seo, use Next.js built-in Metadata API instead.
  • Remove <MetaHeader /> component.
  • Rename metadata files.
  • Add 'use client' directive to components that use client-side code.

Pull Request

This PR Contains

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Test-Case

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Breaking Changes

Additional Info

- Refactor ant design, sandpack, and nprogress usage.
- Remove `next-seo`, use Next.js built-in Metadata API instead.
- Remove `<MetaHeader />` component.
- Rename metadata files.
- Add 'use client' directive to components that use client-side code.
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 8:27pm

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Lighthouse Report

https://blog-5retim68x-sabertazs-projects.vercel.app/

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 95
🟢 accessibility 100
🟡 best-practices 78
🟢 seo 100
🟢 pwa 100

https://blog-5retim68x-sabertazs-projects.vercel.app/posts

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 98
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-5retim68x-sabertazs-projects.vercel.app/tags

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 100
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-5retim68x-sabertazs-projects.vercel.app/books

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 100
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-5retim68x-sabertazs-projects.vercel.app/about

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 98
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

Copy link

socket-security bot commented Apr 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ant-design/nextjs-registry@1.0.0 Transitive: environment +5 1.8 MB madccc

View full report↗︎

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 89.90385% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 95.73%. Comparing base (5392e78) to head (95ba7d3).

Files Patch % Lines
config/seo.ts 7.69% 12 Missing ⚠️
components/SandpackProvider.tsx 0.00% 5 Missing ⚠️
components/ProgressBarProvider.tsx 0.00% 3 Missing ⚠️
components/MDX/MDX.tsx 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   98.43%   95.73%   -2.70%     
==========================================
  Files         175      176       +1     
  Lines         830      844      +14     
  Branches       80       84       +4     
==========================================
- Hits          817      808       -9     
- Misses         12       35      +23     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sabertazimi sabertazimi merged commit 849a184 into main Apr 16, 2024
13 of 15 checks passed
@sabertazimi sabertazimi deleted the feat/app-router branch April 16, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant