Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid link to go to next page for subsections in contracts guides #146

Merged
merged 1 commit into from
May 9, 2024

Conversation

ryabykhms
Copy link
Contributor

While studying this excellent documentation, I noticed that it is impossible to make following transitions by clicking Next:

As far as I understand, since the name of the subsection corresponds to the link id specified in the _category_.json, this id can be removed, which solved the problem of moving to the next existent page.

@smol-ninja
Copy link
Member

Thank you fro the PR @ryabykhms. You are absolutely right.

@smol-ninja smol-ninja self-requested a review May 9, 2024 14:17
@smol-ninja smol-ninja merged commit 07f9e74 into sablier-labs:main May 9, 2024
1 check passed
@ryabykhms
Copy link
Contributor Author

This fix solves this issue #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants