-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit metadata in _afterTokenTransfer
hook
#686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM but we also need to write a test that shows that the metadata event gets emitted on transferFrom
.
We should add for both before and after hooks tests, then. |
Yes. |
@PaulRBerg pushed 2 more commits. Lmk if there is anything left |
test: fix typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for the CI to finish and then you can squash and merge, @andreivladbrg.
Closes #670