Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ignore examples & tests in distribution #54

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Conversation

staabm
Copy link
Member

@staabm staabm commented Nov 22, 2017

would be great if we wouldn't get the examples and tests via composer, when installing with --prefer-dist.

for background see https://www.reddit.com/r/PHP/comments/2jzp6k/i_dont_need_your_tests_in_my_production/

@staabm staabm merged commit 9932388 into master Nov 22, 2017
@staabm staabm deleted the staabm-patch-1 branch November 22, 2017 16:52
@phil-davis
Copy link
Contributor

This is "a good thing" in general. But note that the unit tests from here were being run in sabre-io/dav - the tests/phpunit.xml there had:

      <testsuite name="sabre-event">
          <directory>../vendor/sabre/event/tests/</directory>
      </testsuite>

But actually no tests appear there any more. So actually those tests have not been running in sabre-io/dav CI.

A new version of phpunit is now reporting when there is a test suite defined that does not exist. CI started failing in sabre-io/dav. See sabre-io/dav#1316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants