Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add phpstan #111

Merged
merged 2 commits into from
Oct 22, 2018
Merged

Feature/add phpstan #111

merged 2 commits into from
Oct 22, 2018

Conversation

DeepDiver1975
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2018 •
edited
Loading

Codecov Report

Merging #111 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
- Coverage     88.32%   88.21%   -0.12%     
  Complexity      244      244              
============================================
  Files            15       15              
  Lines           788      789       +1     
============================================
  Hits            696      696              
- Misses           92       93       +1
Impacted Files Coverage Δ Complexity Δ
lib/Client.php 56.96% <0%> (-0.35%) 49 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c795e...13db9a0. Read the comment docs.

@DeepDiver1975
Copy link
Member Author

Looks like this class need some more code coverage love ...

5 similar comments
@DeepDiver1975
Copy link
Member Author

Looks like this class need some more code coverage love ...

@DeepDiver1975
Copy link
Member Author

Looks like this class need some more code coverage love ...

@DeepDiver1975
Copy link
Member Author

Looks like this class need some more code coverage love ...

@DeepDiver1975
Copy link
Member Author

Looks like this class need some more code coverage love ...

@DeepDiver1975
Copy link
Member Author

Looks like this class need some more code coverage love ...

@staabm
Copy link
Member

staabm commented Oct 22, 2018

feel free to add more coverage.

I am also ok with merging anyway, in case you dont have the time right now.

4 similar comments
@staabm
Copy link
Member

staabm commented Oct 22, 2018

feel free to add more coverage.

I am also ok with merging anyway, in case you dont have the time right now.

@staabm
Copy link
Member

staabm commented Oct 22, 2018

feel free to add more coverage.

I am also ok with merging anyway, in case you dont have the time right now.

@staabm
Copy link
Member

staabm commented Oct 22, 2018

feel free to add more coverage.

I am also ok with merging anyway, in case you dont have the time right now.

@staabm
Copy link
Member

staabm commented Oct 22, 2018

feel free to add more coverage.

I am also ok with merging anyway, in case you dont have the time right now.

@DeepDiver1975
Copy link
Member Author

Looks like this class need some more code coverage love ...

@DeepDiver1975 DeepDiver1975 merged commit 3577f01 into master Oct 22, 2018
@staabm staabm deleted the feature/add-phpstan branch October 22, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepDiver1975 @staabm