Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Trying to access array offset on value of type bool" in 7.4 #121

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

remicollet
Copy link
Contributor

Without:

1) Sabre\HTTP\Auth\DigestTest::testInvalidDigest2
Trying to access array offset on value of type bool

/work/GIT/sabre-http/lib/Auth/Digest.php:124
/work/GIT/sabre-http/lib/Auth/Digest.php:94
/work/GIT/sabre-http/tests/HTTP/Auth/DigestTest.php:99

Also see sabre-io/dav#1187

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #121 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #121      +/-   ##
============================================
+ Coverage     93.51%   93.52%   +0.01%     
- Complexity      250      251       +1     
============================================
  Files            15       15              
  Lines           817      819       +2     
============================================
+ Hits            764      766       +2     
  Misses           53       53
Impacted Files Coverage Δ Complexity Δ
lib/Auth/Digest.php 96.42% <100%> (+0.13%) 20 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e41e8b1...6f47f70. Read the comment docs.

@staabm staabm merged commit 987e14a into sabre-io:master Sep 11, 2019
@staabm
Copy link
Member

staabm commented Sep 11, 2019

thx remi

@remicollet remicollet deleted the issue-74 branch September 11, 2019 12:50
joec4i pushed a commit to joec4i/sabre-http that referenced this pull request Feb 24, 2021
joec4i added a commit to bigcommerce/sabre-http that referenced this pull request Feb 24, 2021
fix "Trying to access array offset on value of type bool" in 7.4 (sabre-io#121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants