-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to PHPUnit 8 #142
Update to PHPUnit 8 #142
Conversation
refactored unittest with rectorphp to work with phpunit8
thx, looks good. remaining todos in composer.json:
adjust travis.yml accordingly |
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=========================================
Coverage 93.64% 93.64%
Complexity 257 257
=========================================
Files 15 15
Lines 834 834
=========================================
Hits 781 781
Misses 53 53 Continue to review full report at Codecov.
|
-> ah prefer-lowest build :-) |
…into phpunit-8-upgrade
As consequence of uplifting min PHP Version to 7.2 because of PHPUnit uplift to 8 -> CI Checks for PHP < 7.2 no longer neccessary
Co-Authored-By: Markus Staab <maggus.staab@googlemail.com>
todos done, CI checks are successfull. |
looks really good, thx. well done! |
Updated from PHPUnit version 7 -> 8
Codebase changes were needed:
!important: PHPUnit8 requires PHP ^7.2 -> PHP version has to be updated bevor merging.
because of that not all checks are successfull.
//cc @staabm