Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHPUnit 8 #142

Merged
merged 8 commits into from
Jan 23, 2020
Merged

Update to PHPUnit 8 #142

merged 8 commits into from
Jan 23, 2020

Conversation

C0pyR1ght
Copy link
Contributor

Updated from PHPUnit version 7 -> 8

Codebase changes were needed:

  • Updated Composer PHPUnit version to ^8
  • Refactored test to work with PHPUnit8
  • Added PHPUnit Cache to gitignore

!important: PHPUnit8 requires PHP ^7.2 -> PHP version has to be updated bevor merging.
because of that not all checks are successfull.

//cc @staabm

@staabm
Copy link
Member

staabm commented Jan 22, 2020

thx, looks good.

remaining todos in composer.json:

  • uplift min php requirement to 7.2
  • drop old phpunit versions

adjust travis.yml accordingly

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #142   +/-   ##
=========================================
  Coverage     93.64%   93.64%           
  Complexity      257      257           
=========================================
  Files            15       15           
  Lines           834      834           
=========================================
  Hits            781      781           
  Misses           53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e60e3...8659e8b. Read the comment docs.

composer.json Outdated Show resolved Hide resolved
@staabm
Copy link
Member

staabm commented Jan 23, 2020

interessting.. the php 7.4 build uses phpunit 6.x.. it should be phpunit 8.x though

-> ah prefer-lowest build :-)

C0pyR1ght and others added 4 commits January 23, 2020 11:57
As consequence of uplifting min PHP Version to 7.2 because of PHPUnit uplift to 8 -> CI Checks for PHP < 7.2 no longer neccessary
Co-Authored-By: Markus Staab <maggus.staab@googlemail.com>
@C0pyR1ght
Copy link
Contributor Author

todos done, CI checks are successfull.
ready for merging.

@staabm

@staabm staabm merged commit fcd20ee into sabre-io:master Jan 23, 2020
@staabm
Copy link
Member

staabm commented Jan 23, 2020

looks really good, thx.

well done!

@C0pyR1ght C0pyR1ght deleted the phpunit-8-upgrade branch January 23, 2020 11:51
@phil-davis phil-davis mentioned this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants