Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with PHP 8.0 #160

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Test with PHP 8.0 #160

merged 1 commit into from
Oct 2, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 2, 2020

  1. sort out variables in .travis.yml for selecting to run php-cs-fixer, phpunit and phpstan
  2. Add a matrix entry to run just phpunit on Ubuntu 20.04 "focal" with "nightly" PHP (which is the way to get PHP 8.0 at the moment)
  3. When not running php-cs-fixer, explicitly remove it from composer.json (because php-cs-fixer does not yet support PHP 8.0, so composer cannot sort out dependencies if we have PHP 8.0 and php-cs-fixer 2.* together)
  4. Fix the constructor declarations that have an optional parameter before a required parameter (PHP 8.0 complains about these)

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #160   +/-   ##
=========================================
  Coverage     93.67%   93.67%           
  Complexity      259      259           
=========================================
  Files            15       15           
  Lines           838      838           
=========================================
  Hits            785      785           
  Misses           53       53           
Impacted Files Coverage Δ Complexity Δ
lib/Auth/AbstractAuth.php 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
lib/Auth/Digest.php 96.42% <100.00%> (ø) 20.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e8681...d2e898b. Read the comment docs.

@phil-davis phil-davis marked this pull request as ready for review October 2, 2020 14:44
@phil-davis phil-davis changed the title Test with php 8.0 Test with PHP 8.0 Oct 2, 2020
@phil-davis
Copy link
Contributor Author

PR #154 started this off. Thanks @cedric-anne
I managed to sort out a way to make unit tests on PHP 8.0 run and pass.

Copy link
Contributor

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@staabm staabm merged commit 2d49a4f into sabre-io:master Oct 2, 2020
@staabm
Copy link
Member

staabm commented Oct 2, 2020

Looks great, thx

@phil-davis phil-davis deleted the test-with-php-8.0 branch October 3, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants