Ensure $_SERVER keys are read as strings. #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looping over an array with foreach php will automatically convert numeric values to integers. Since the key here is passed to substr it has to be of string type. This commit explicitly convert the key value to string.
|
I rebased this. @staabm please review. Hold that - I didn't look at all, the code is not valid. |
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
============================================
+ Coverage 89.67% 89.72% +0.04%
- Complexity 256 260 +4
============================================
Files 15 15
Lines 891 895 +4
============================================
+ Hits 799 803 +4
Misses 92 92
Continue to review full report at Codecov.
|
staabm
approved these changes
Nov 2, 2021
|
Oops, apparently I can mess up even a simple pull request like this one... Good to know I guess. Thank you for the fix, and sorry for my php-dyslexia 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looping over an array with foreach php will automatically convert
numeric values to integers. Since the key here is passed to substr it
has to be of string type. This commit explicitly convert the key value
to string.
I found this by accident by setting "env[LC_MESSAGES] = C.UTF-8" in my php-fpm pool configuration. For whatever reason this translated to '"6" => "C.UTF-8' in the $_SERVER array, which caused tons of headache while troubleshooting my nextcloud installation. I havn't really verified if this is the only bug of this kind (I fixed my problem by updating the php-configuration), but since I found this bug I thought I could at least report it.